Skip to content

K8SPS-269 add labels for all objects created by operator #989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

K8SPS-269 add labels for all objects created by operator #989

wants to merge 5 commits into from
+12 −8

Conversation

nmarukovich
Copy link
Contributor

@nmarukovich nmarukovich commented Aug 8, 2025 •
edited by jira bot
Loading

K8SPS-269 Powered by Pull Request Badge

CHANGE DESCRIPTION

Problem:
I rechecked all objects created by operator and only cm doesn't have labels. The labels to cm were added in this PR.

Cause:
Short explanation of the root cause of the issue if applicable.

Solution:
Short explanation of the solution we are providing with this PR.

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Are all needed new/changed options added to the Helm Chart?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported PS version?
  • Does the change support oldest and newest supported Kubernetes version?

@pull-request-size pull-request-size bot added the size/S 10-29 lines label Aug 8, 2025
@hors hors added this to the v0.12.0 milestone Aug 8, 2025
@JNKPercona
Copy link
Collaborator

Test name Status
version-service passed
async-ignore-annotations passed
auto-config passed
config passed
config-router passed
demand-backup failure
async-data-at-rest-encryption passed
gr-data-at-rest-encryption passed
gr-demand-backup passed
gr-demand-backup-haproxy passed
gr-finalizer passed
gr-haproxy passed
gr-ignore-annotations passed
gr-init-deploy passed
gr-one-pod passed
gr-recreate passed
gr-scaling passed
gr-scheduled-backup passed
gr-security-context passed
gr-self-healing passed
gr-tls-cert-manager passed
gr-users passed
haproxy passed
init-deploy passed
limits passed
monitoring passed
one-pod passed
operator-self-healing passed
recreate passed
scaling passed
scheduled-backup passed
service-per-pod passed
sidecars passed
smart-update passed
storage passed
tls-cert-manager passed
users passed
pvc-resize passed
We run 38 out of 38

commit: 5c0ce32
image: perconalab/percona-server-mysql-operator:PR-989-5c0ce327

hors
hors requested changes Aug 15, 2025
View reviewed changes
Copy link
Collaborator

@hors hors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nmarukovich please add to the PR description which labels were added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hors hors hors requested changes

@egegunes egegunes Awaiting requested review from egegunes egegunes is a code owner

@pooknull pooknull Awaiting requested review from pooknull pooknull is a code owner

@gkech gkech Awaiting requested review from gkech gkech is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
size/S 10-29 lines
Projects
None yet
Milestone
v0.12.0
Development

Successfully merging this pull request may close these issues.
3 participants
@nmarukovich @JNKPercona @hors